[email protected]: Update weatherstack.js

[naufragoweb]

@tipichris
*Support for free and paid plans
*Automatic day/night icons
*Robust error handling
*Internationalization
*Code optimized

[rcalixte]

@naufragoweb Can you hold off on pull requests that modify this desklet until we have a chance to synchronize on feedback? There are some issues that prevent these from being able to be merged as-is and it would help if you understand why so that you can implement future changes with those changes in mind.

[naufragoweb]

@rcalixte
Greetings... Ok, I'm going to suspend pull requests.

[rcalixte]

Greetings... Ok, I'm going to suspend pull requests.

What you're aiming to do is appreciated but we need to strive for maintainable and readable code. As a minimum, you've deviated from the established whitespace structuring and over-indexed on brevity. I was going to take the time to send this feedback after demonstrating the desired approach with your first pull request that is still open but then came more. 😅

Is this something you can take on or would an example or two help first?

[naufragoweb]

What you're aiming to do is appreciated but we need to strive for maintainable and readable code. As a minimum, you've deviated from the established whitespace structuring and over-indexed on brevity. I was going to take the time to send this feedback after demonstrating the desired approach with your first pull request that is still open but then came more. 😅

Thank you for the honest and constructive feedback—I really appreciate you taking the time to guide me on this. You’re absolutely right about prioritizing maintainability and readability, and I apologize for the deviations in whitespace and over-optimization for brevity. That wasn’t my intention, and I’ll make sure to align with the team’s standards moving forward.

If it’s better for the project, I’m completely fine with having my recent pull requests rejected so I can revisit the code with your feedback in mind. I don’t want to create unnecessary work for anyone, and my goal is to contribute helpfully, not disrupt the workflow.

If possible, an example or two of the desired approach would be incredibly helpful, just so I can correct my mistakes more efficiently. But if you’re short on time, I’m happy to adjust things independently based on your notes.

Thanks again for your patience—I’ll strive to improve and match the team’s expectations. Let me know how you’d prefer to proceed.

[rcalixte]

If it’s better for the project, I’m completely fine with having my recent pull requests rejected so I can revisit the code with your feedback in mind. I don’t want to create unnecessary work for anyone, and my goal is to contribute helpfully, not disrupt the workflow.

Not rejected since the fixes need to happen. We just need to structure it slightly differently. That's why I marked them as a draft. It's a good first pass because it's functional.

If possible, an example or two of the desired approach would be incredibly helpful, just so I can correct my mistakes more efficiently. But if you’re short on time, I’m happy to adjust things independently based on your notes.

I'd started on the first pull request but we can use this one too. This could be a good learning and collaboration opportunity for both of us.