-
Notifications
You must be signed in to change notification settings - Fork 123
focus-new-window@mdpenguin: add exclude list setting #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Allow users to specify programs whose windows should not receive focus.
|
cc @mdpenguin |
mdpenguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks useful but I'd prefer to see the following before merging the changes:
- Add
"dependency": "!raiseSome"to the new setting so that it only shows when "Raise windows only of listed programs" is not selected. - Rephrase tooltip to "Comma separated list of programs that should not have their windows automatically receive focus" so that it's not implied that users can't click on the window to give it focus.
- Update the Options section of Readme.md as follows:
## Options
- Raise window only of listed programs
- When selected, only windows from the programs that you list will be affected by the extension
- When unselected, windows from all programs will be affected by the extension unless included in "Programs to exclude"
- Programs to include
- A comma separated list of programs to include
- The list is not case sensitive and spaces between programs is optional
- Programs to exclude
- A comma separated list of programs that should not have their windows automatically receive focus
- The list is not case sensitive and spaces between programs is optional|
@mdpenguin I made the requested changes and improved the logic so that the include/exclude lists are used depending on the raiseSome setting. |
mdpenguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. I'm fine with it as it is, but it might be better to change both the setting element and variable from programList to includeList so that it's consistent and clearer to anyone who works on this in the future.
Allow users to specify programs whose windows should not receive focus.
In my case, the extension works correctly with all applications except https://flathub.org/en/apps/com.github.IsmaelMartinez.teams_for_linux, where every message notification caused the application to come into focus. The list of excluded applications solves this problem.