settings.js: remove file monitor #12819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File monitor doesn't serve any useful purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File monitor doesn't serve any useful purpose.
The only change is that a settings file will not be automatically be reloaded after being manually edited. The only place where a settings file is changed outside of
settings.jsis inxlet-settings.pybut this callsremoteUpdate()method to trigger callbacks (via dbus).If changing a setting's bound value via
settings.jswas intended to trigger it's callback, then this hasn't worked since at least 2016 (f97a3e4), so this PR makes no change in that respect. If it's desired to trigger callbacks on every change (viasettings.js) to a setting's value then a file monitor is an unnecessary and very inefficient way to do it anyway.Mitigates against #9920 , linuxmint/cinnamon-spices-applets#6866 (comment)