cs_nightlight.py: Handle typed user input into the night light module (manual schedule) - fixes #12818 #12826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12818
The code allows the manually scheduled times in the night light module to be specified through typed user input in addition to clicking the +/- buttons.
The hours and minutes are checked to make sure they follow the guidelines of the 15 minute adjustments and if hours and/or minutes go above 24 and 60, respectively. In the videos, if the user types in any minutes not divisible by 15, it defaults to zero.
Here are two videos where this PR is applied and the time format is set to AM/PM and 24-hr, respectively:
AM/PM:
cs_nightlight_fix_AMPM.mp4
24-hr:
cs_nightlight_fix_24hr.mp4