AppStream metadata fixes #391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appstreamcli seems to require the existence of a description without a 'xml:lang' attribute. This makes sense if you think about the "lang-less" description as the default one, and the translated ones as overrides.
The AppStream metadata spec states that the description "should be translated by-paragraph". Looking at other metainfo files, it seems that most treat this as meaning "translations should immediately follow the non-translated paragraph".
This tag informs AppStream consumers how to launch the application.
AppStream IDs are recommended to follow an reverse-DNS scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the AppStream metadata file:
Removes the
xml:lang="en"attribute from description paragraph. While the AppStream specification doesn't really say anything about this1, it seems thatappstreamclitreats translated descriptions as overrides, and expects the existence of a default description without a language marker.Adds the
<launchable>tag to inform consumers how to launch the application2.Changes the ID to
com.linuxmint.timeshift(and renames the file accordingly), as AppStream IDs are expected to follow a reverse-DNS{tld}.{vendor}.{product}scheme3.Footnotes
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-description ↩
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable ↩
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-id-generic ↩