add "timeshift" to the tempdir names #395
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some aged folders in
/tmp
on my computer.I first didnt know where they come from. I found a file "0" and "status" inside all of them. So it seems they are from timeshift. To let users know what program created those files (and give the some information to decide if they want to delete those files), I added the string "timeshift" to those folders.
It also seems like the "exitCode file" was not used. But maybe i have overlooked some place?
I think the whole class is a bit weird. Instead of writing every little command into a script and executing that, it might be better to execute some shorter commands directly. Instead of watching the existence of the "status" file its probably beneficial to check for the pid of the specific progress directly. This looks like a job for https://valadoc.org/glib-2.0/GLib.ChildWatchSource.html