Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "timeshift" to the tempdir names #395

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ygerlach
Copy link
Contributor

@ygerlach ygerlach commented Mar 8, 2025

I noticed some aged folders in /tmp on my computer.

I first didnt know where they come from. I found a file "0" and "status" inside all of them. So it seems they are from timeshift. To let users know what program created those files (and give the some information to decide if they want to delete those files), I added the string "timeshift" to those folders.

It also seems like the "exitCode file" was not used. But maybe i have overlooked some place?

I think the whole class is a bit weird. Instead of writing every little command into a script and executing that, it might be better to execute some shorter commands directly. Instead of watching the existence of the "status" file its probably beneficial to check for the pid of the specific progress directly. This looks like a job for https://valadoc.org/glib-2.0/GLib.ChildWatchSource.html

@ygerlach
Copy link
Contributor Author

I have now added some more possible temp directories. Those should provide valid fallback if root is full and the computer has other another drive mounted on /var as some do.
I also choose to include /dev/shm as fallback. On "recent" linux distros this is expected to be a mounted tmpfs and should therefore never be affected by a full drive (only full memory).

This now fixes #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant