Skip to content

lidarr: flac2mp3 release 2.5.0 #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

TheCaptain989
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

  • New: Uses temporary file for writing
  • New: Added WSL environment checks
  • Fixes: Resample FLAC from 24-bit 96kHz to 16-bit 44.1kHz TheCaptain989/lidarr-flac2mp3#54
  • Minor log output changes
  • Minor variable scoping changes in some functions
  • Dockerfile case
  • Added Lidarr version check error message
  • Reordered some dependency checks
  • Debug log messages with version
  • Log temporary name and new track name
  • Standardized logs to match other project

Benefits of this PR and context:

New ability to resample to same codec using temporary files.

How Has This Been Tested?

Separate Docker development environment, with custom test script plus manual testing.
Functional changes deployed from development repo and running in personal environment.

Source / References:

None.

@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_1029

@LinuxServer-CI
Copy link

PR build pushed to ghcr.io/linuxserver/mods:pull_request_1029

@aptalca aptalca self-assigned this May 4, 2025
@github-project-automation github-project-automation bot moved this from PRs to PRs Approved in Issue & PR Tracker May 5, 2025
@aptalca aptalca merged commit 7cc5e27 into linuxserver:lidarr-flac2mp3 May 5, 2025
3 checks passed
@LinuxServer-CI LinuxServer-CI moved this from PRs Approved to Done in Issue & PR Tracker May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants