-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mongo authMechanism config, make creds optional #128
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here is the pushed image/manifest for this PR:
|
Thanks for the PR, but our users already have a hard enough time getting mongodb set up even with us providing the ready made sh script. This PR would complicate things further and significantly increase our support burden. Our init steps for setting mongo credentials only work on first run anyway. Users are free to edit system.properties in the config folder to customize the mongo address and params however they like. |
I could theoretically imagine how this change would make it more complicated for users to set up mongo, but I can't figure out how a 15 line change to a shell script is a significant support burden. I made this PR because I had slight inconvenience with current setup process, but if it's really a big deal - feel free to close this at your discretion. |
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
Description:
Same as title says, adding more config options for Mongo, specifically to support running with FerretDB instead of Mongo
Benefits of this PR and context:
No need to run old Mongo version
How Has This Been Tested?
Will be tested in my cluster when image is built
Source / References: