Skip to content

Discount bandit#719

Closed
Findarato wants to merge 34 commits intolinuxserver:masterfrom
Findarato:discount-bandit
Closed

Discount bandit#719
Findarato wants to merge 34 commits intolinuxserver:masterfrom
Findarato:discount-bandit

Conversation

@Findarato
Copy link
Copy Markdown
Contributor

@Findarato Findarato commented Nov 25, 2024

Added support for discount-bandit

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description

Benefits of this PR and context

How Has This Been Tested?

I am using this in my homelab right now.

Source / References

Findarato added 5 commits April 9, 2024 12:53
@Findarato
Merge pull request #4 from linuxserver/master
c7c393c 
[pull] master from linuxserver:master
@Findarato
Merge branch 'master' of github.com:Findarato/reverse-proxy-confs
d5c3676
@Findarato
Merge pull request #5 from linuxserver/master
22a4a5c 
[pull] master from linuxserver:master
@Findarato
Merge pull request #6 from linuxserver/master
126b571 
[pull] master from linuxserver:master
@Findarato
❇️ Added support for discountbandit
7053b1f 
Signed-off-by: Joseph Harry <findarato@gmail.com>
@Findarato Findarato mentioned this pull request Nov 25, 2024
Closed
1 task
@Findarato
Copy link
Copy Markdown
Contributor Author

Findarato commented Nov 25, 2024

I do not think the error is with my pull.

pagdot
pagdot suggested changes Nov 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@pagdot pagdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed a few cosmetic things :)

@Findarato
Copy link
Copy Markdown
Contributor Author

Findarato commented Dec 18, 2024

The Check Samples is failing on error pages not related to the pull

@aptalca
Copy link
Copy Markdown
Member

aptalca commented Dec 19, 2024

You might want to do a proper rebase and force push. A brand new PR passes the conf validity check: #723

Also, please remove the http2 directives

@aptalca
Copy link
Copy Markdown
Member

aptalca commented Dec 19, 2024

hold on, I take it back

You double included the proxy.conf in the subfolder.conf.sample

drizuid
drizuid requested changes Dec 21, 2024
View reviewed changes
@Findarato Findarato requested a review from drizuid December 26, 2024 16:23
drizuid
drizuid requested changes Dec 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@drizuid drizuid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#719 (comment)

Findarato and others added 7 commits January 1, 2025 16:20
@Findarato
Merge branch 'master' into discount-bandit
d0fe17e
@Findarato
🎨 Cleaned up some formatting
e687ccc 
Signed-off-by: Joseph Harry <findarato@gmail.com>
@Findarato
❇️ Added support for discountbandit
78770b9 
Signed-off-by: Joseph Harry <findarato@gmail.com>
@Findarato
🐛 Fixed comments in pull request
215e489 
Signed-off-by: Joseph Harry <findarato@gmail.com>
@drizuid @Findarato
update port and name
411b862
@drizuid @Findarato
Update castopod.subdomain.conf.sample
6bc210f
@Findarato
🐛 Fix(duplicate): Removed duplicate config entries
99c5dc5 
Signed-off-by: Joseph Harry <findarato@gmail.com>
DougEdey and others added 13 commits January 1, 2025 16:23
@Findarato
Copy link
Copy Markdown
Contributor Author

Findarato commented Jan 1, 2025

I am mostly sure I did the rebase correctly. Crazy how many things change with this repo while I was fixing the mistakes.

@Findarato Findarato requested a review from drizuid January 1, 2025 22:33
Findarato
Findarato commented Jan 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@Findarato Findarato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Findarato
Copy link
Copy Markdown
Contributor Author

Findarato commented Jan 1, 2025

#719 (comment)

I have completed it with e2b2c6c

@YouveGotMeowxy

This comment was marked as off-topic.

Sign in to view
drizuid
drizuid requested changes Jan 11, 2025
View reviewed changes
calibre-web.subdomain.conf.sample
Copy link
Copy Markdown
Member

@drizuid drizuid Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is calibre-web in this pr?

@YouveGotMeowxy

This comment was marked as off-topic.

Sign in to view
@YouveGotMeowxy

This comment was marked as abuse.

Sign in to view
@LinuxServer-CI
Copy link
Copy Markdown

LinuxServer-CI commented Feb 12, 2025

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Apr 13, 2025
@LinuxServer-CI
Copy link
Copy Markdown

LinuxServer-CI commented May 14, 2025

This pull request is locked due to inactivity

@linuxserver linuxserver locked as resolved and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@drizuid drizuid drizuid requested changes

+1 more reviewer

@pagdot pagdot pagdot requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

closed-pr-activity no-pr-activity

Projects

Issue & PR Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Findarato @aptalca @YouveGotMeowxy @LinuxServer-CI @pagdot @drizuid @DougEdey @jgillman @bvandenabbeele