Skip to content

Multiple Bug Fixes #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

laduchesneau
Copy link
Collaborator

@laduchesneau laduchesneau commented May 1, 2025

This PR includes multiple bug fixes and a minor change to make code more readable.

  • Changed the receiver names for Receivable, Transmittable and Transceivable. They were all using t, i change it to tr,tx, and trx, so it more easy to understand what the function receiver is.
  • The closing function from transmittable and receivable, no longer calls the OnClosed handler, they will now call the transceivable closing function that will now handle closing process and call the OnClosed handle.
  • The only closing state that will not trigger OnClosed call is ExplicitClosing. This is the current behavior, only the comment has been change to indicate this behavior.
  • Removed useless call to close() in the rebind() function. rebind() is only called when closing() fucntion has been called anyway.
  • Added new closing state to help indicate when a bind has been closed because the user request it after handling a expired request.
  • Fixed a bug in the windowCleanup function that would wait indefinitely on wg.wait function.
  • Removed erroneous multiplication of milliseconds for some timers

Will resolve #170

…ng function in transceivable. All close action will now be triggered by transceivable
… already a Time.Duration, the user can set whatever time period they want, sec or millisecond, but when multiplying by millisecond in the lib, the value is use will be erroneous

this will be a breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnClosed not always called when session is not alive
1 participant