-
Notifications
You must be signed in to change notification settings - Fork 19
feat(cli): move cogify create-config into cli-config package BM-1261 #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): move cogify create-config into cli-config package BM-1261 #3432
Conversation
5ea4ca1 to
3f259c6
Compare
b0780de to
df954ea
Compare
@Wentao-Kuang - Should we adjust the paths ...
if (isArgo()) {
// Path to where the config is located
await fsa.write(fsa.toUrl('/tmp/cogify/config-path'), urlToString(outputPath));
// A URL to where the imagery can be viewed
await fsa.write(fsa.toUrl('/tmp/cogify/config-url'), urlToString(url));
}
...Update: We'll leave the paths as they are. No changes. |
|
@Wentao-Kuang - Which way should we be initialising the logger for each command? Most of them (e.g. action.bundle.assets.ts) do it this way: const logger = getLogger(this, args, 'cli-config');But the action.import.ts command does it this way: const logger = LogConfig.get();Is one way better than the other? |
|
Good to know. I'll update the action.import.ts command now. |
# [v8.0.0](v7.17.0...v8.0.0) **Please Note this is a work in progress release, please remain on v7 until the command line changes have been finalized** ### Bug Fixes * **cli:** update landing deploy script with new cli-config package BM-1260 ([#3431](#3431)) ([4d7e86d](4d7e86d)), closes [/github.com/linz/basemaps/blob/e527a04fec65c82f8577642493e8fcb475762243/packages/landing/scripts/deploy.mjs#L1](https://github.com//github.com/linz/basemaps/blob/e527a04fec65c82f8577642493e8fcb475762243/packages/landing/scripts/deploy.mjs/issues/L1) * ensure all linzjs packages are correctly labeled as deps ([#3439](#3439)) ([de9df87](de9df87)), closes [#3438](#3438) * ensure api key blocks are set in ci/cd ([#3442](#3442)) ([28f6403](28f6403)) ### Features * **cli-vector:** Extract cli to load schema json and prepare jobs to process vector mbtiles. BM-1267 ([#3429](#3429)) ([db113e2](db113e2)) * **cli:** add cli-config package BM-1260 ([#3428](#3428)) ([4ca5a47](4ca5a47)) * **cli:** move cogify create-config into cli-config package BM-1261 ([#3432](#3432)) ([5f72430](5f72430)) * **cli:** rename cogify package to cli-raster BM-1262 ([#3433](#3433)) ([36d4449](36d4449)) * **cli:** update cli-package commands to cmd-ts BM-1259 ([#3427](#3427)) ([46cc342](46cc342))
Motivation
The
create-configcommand of thecogifypackage should live alongside the otherbasemaps-config-related commands in the newcli-configpackage.Modifications
cogify-configcommand from thecogifypackage to thecli-configpackage.clipackage as aconfig createsub-command.sharedpackage. So, this work also updates various functions to use the new shared equivalents instead, removing the singular copies in the process.Verification
check
bin/bmc.js config create-configruns correctly