fix: ensure all linzjs packages are correctly labeled as deps #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
there is a weird behaviour in this monorepo that when importing packages that are present inside the monorepo can be imported freely anywhere inside the monorepo, but when the package is published it needs to exsit inside the package.json or it will not be installed correcttly.
We have a script that detects when this happens
scripts/detect.unlinked.dep.mjsbut it was only functioning for@basemaps/*packages in this repository there are a few@linzjs/pacakges.Modifications
Ensure linzjs packages are also checked as part of CI
Add the missing links between a few packages and
@linzjs/geojsonand@linzjs/metricsVerification
detect.unlinked.dep.mjsfound these packages once it was updated to include looking for@linzjsFixes #3438