Skip to content

feat(cli-vector): Support NZTM mbtiles creation.BM-1300 #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Wentao-Kuang merged 27 commits into from
Jun 17, 2025
Merged

feat(cli-vector): Support NZTM mbtiles creation.BM-1300 #3452

Wentao-Kuang merged 27 commits into from
Jun 17, 2025

Conversation

@Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Jun 9, 2025 •
edited
Loading

Motivation

Upgrade ETL process to support NZTM mbtiles creation

Modifications

  • Using the function locationTransform from landing package to convert the geometry into NZTM tilematrix during the generalisation step. Then apply the zoom level offset for it.
  • Fixes for the labels are not correctly set the zoom levels
  • Fixes the simplify that reset the modified the zoom levels, move the modify feature after simplification.

Verification

Argo workflow

Previews: WebMercatorQuad and NZTM2000Quad

@Wentao-Kuang Wentao-Kuang added the container build pull request container for testing label Jun 9, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 9, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 9, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 9, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 9, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 10, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 10, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 10, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 10, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 10, 2025
@tawera-manaena
Copy link
Contributor

tawera-manaena commented Jun 13, 2025 •
edited
Loading

✅ The outputs look good on my end. No issues that I can see. I'll review the code in a moment.

@Wentao-Kuang
Copy link
Contributor Author

Wentao-Kuang commented Jun 13, 2025

✅ The outputs look good on my end. No issues that I can see. I'll review the code in a moment.

I just found the major highways is missing. Will investigate this later.

@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 13, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 13, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 15, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 15, 2025
@Wentao-Kuang Wentao-Kuang added container build pull request container for testing and removed container build pull request container for testing labels Jun 15, 2025
ccbblin
ccbblin previously approved these changes Jun 16, 2025
View reviewed changes
tawera-manaena
tawera-manaena reviewed Jun 16, 2025
View reviewed changes
@tawera-manaena
Copy link
Contributor

tawera-manaena commented Jun 16, 2025 •
edited
Loading

Can we change the following line:

basemaps/packages/cli-vector/src/modify/layers/water.ts

Line 9 in 0406384

* Processes a 'water_polygons' layer feature.

to this:

 * Processes a 'water_lines' or 'water_polygons' layer feature.

@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Jun 17, 2025
Merged via the queue into master with commit f601a73 Jun 17, 2025
17 of 19 checks passed
@Wentao-Kuang Wentao-Kuang deleted the feat/nztm-mbtiles branch June 17, 2025 02:53
@ccbblin ccbblin mentioned this pull request Jun 17, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 17, 2025
@ccbblin
release: v8.3.0 (#3461)
fe8bbf9 
### Motivation

# [8.3.0](v8.2.0...v8.3.0)
(2025-06-17)


### Bug Fixes

* **cli-vector:** collapse large analysis report in pr comment
([#3457](#3457))
([19a4d85](19a4d85))
* **infra:** increase lambda tiler memory to 3072MB
([#3459](#3459))
([786bb54](786bb54))
* **landing:** Fix debug page automatically hide topographic-v2. BM-1302
([#3456](#3456))
([53134c0](53134c0))


### Features

* **cli-config:** Generate topographic previews with the v2 in the url.
BM-1203 ([#3455](#3455))
([1a2f220](1a2f220))
* **cli-vector:** Support NZTM mbtiles creation.BM-1300
([#3452](#3452))
([f601a73](f601a73))
* **landing:** Support NZTM vector Links in the menu page. BM-1301
([#3458](#3458))
([a57059e](a57059e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tawera-manaena tawera-manaena tawera-manaena left review comments

@ccbblin ccbblin ccbblin approved these changes

Assignees

No one assigned

Labels

container build pull request container for testing

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wentao-Kuang @tawera-manaena @ccbblin