Skip to content

fix(landing): Fix debug page automatically hide topographic-v2. BM-1302 #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wentao-Kuang merged 2 commits into from
Jun 13, 2025
Merged

fix(landing): Fix debug page automatically hide topographic-v2. BM-1302 #3456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121c764
Fix debug page automatically hide topographic-v2.
Wentao-Kuang Jun 12, 2025
4c43a75
Merge branch 'master' into fix/shortbread-url
Wentao-Kuang Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/landing/src/config.map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class MapConfig extends Emitter<MapConfigEvents> {
}

get isVector(): boolean {
return this.layerId === 'topographic';
return this.layerId.startsWith('topographic');
}

/** Key to reference the combined layer & style */
Expand Down Expand Up @@ -151,7 +151,7 @@ export class MapConfig extends Emitter<MapConfigEvents> {
this.labels = labels !== 'false';
}

if (this.layerId === 'topographic' && this.style == null) this.style = 'topographic';
if (this.layerId.startsWith('topographic') && this.style == null) this.style = this.layerId;
this.emit('tileMatrix', this.tileMatrix);
this.emit('layer', this.layerId, this.style, this.pipeline, this.imageFormat);
if (previousUrl !== MapConfig.toUrl(this)) this.emit('change');
Expand Down
2 changes: 1 addition & 1 deletion packages/landing/src/debug.map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export class DebugMap {
const layers = styleJson.layers?.filter((f) => f.type !== 'background' && f.source === 'LINZ Basemaps') ?? [];

// Do not hide topographic layers when trying to inspect the topographic layer
if (Config.map.layerId === 'topographic') return;
if (Config.map.isVector) return;
// Force all the layers to be invisible to start, otherwise the map will "flash" on then off
for (const layer of layers) {
const paint = (layer.paint ?? {}) as Record<string, unknown>;
Expand Down