Skip to content

feat(cli-config): be very clear that imagery is about to be removed from the config #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wentao-Kuang merged 1 commit into from
Jun 17, 2025
Merged

feat(cli-config): be very clear that imagery is about to be removed from the config #3460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/cli-config/src/cli/action.import.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,16 @@ async function outputChange(
} else await outputNewLayers(mem, layer, inserts, configPath, true);
}

if (inserts.length > 0) md.push('# Aerial Imagery Inserts', ...inserts);
if (updates.length > 0) md.push('# Aerial Imagery Updates', ...updates);
if (inserts.length > 0) md.push('# 🟩🟩 Aerial Imagery Inserts 🟩🟩', ...inserts);
if (updates.length > 0) md.push('# 🟡🟡 Aerial Imagery Updates 🟡🟡', ...updates);

// Some layers were not removed from the old config so they no longer exist in the new config
if (oldData.layers.length > 0) {
md.push('# Aerial Imagery Deletes', ...oldData.layers.map((m) => `- ${m.title}`));
md.push(
'# 🚨🚨 Aerial Imagery Deletes 🚨🚨',
' Basemaps layers will be removed for the following layers: ',
...oldData.layers.map((m) => `- ${m.title}`),
);
}

// Output for individual tileset config changes or inserts
Expand Down Expand Up @@ -296,7 +300,7 @@ async function outputChange(
if (reportFile) {
md.push(
'## Tile SIZE Analyse Report',
'<details><summary>🟩WebMercator🟩</summary>',
'<details><summary>🟩 WebMercator 🟩</summary>',
reportFile.toString(),
'</details>',
);
Expand Down
Loading