Skip to content

Conversation

@ccbblin
Copy link
Contributor

@ccbblin ccbblin commented Aug 19, 2025

Motivation

Change the behaviour of the quick change button on https://basemaps.linz.govt.nz/ to cycle between the following maps:

  1. Aerial
  2. Topographic
  3. NZ Topo Gridless
  4. TopoLite
  5. Hillshade Igor DEM
  6. Hillshade Igor DSM

Verification

visual

@ccbblin ccbblin marked this pull request as ready for review August 19, 2025 04:24
@ccbblin ccbblin requested a review from a team as a code owner August 19, 2025 04:24
@ccbblin ccbblin changed the title feat(landing): quick change cycles through more basemaps feat(landing): quick change cycles through more basemaps BM-1293 Aug 19, 2025
@tawera-manaena
Copy link
Contributor

tawera-manaena commented Aug 21, 2025

Text on Hover: Alternative

@JBLINZ - Right now, we display the next layer's id as part of the title tag (the helper text that appears on hover). Thoughts on displaying the next layer's title instead?

Layer ID Layer Title

Doing so requires cloning the layers state from the higher level MapConfig component (at least for my proof-of-concept). So, if it's not that important, I say we stick with the next layer's id value.

Actually, you could just hard-code the titles. Anyway...

@JBLINZ
Copy link
Contributor

JBLINZ commented Aug 21, 2025

Text on Hover: Alternative

@JBLINZ - Right now, we display the next layer's id as part of the title tag (the helper text that appears on hover). Thoughts on displaying the next layer's title instead?

Layer ID Layer Title

Doing so requires cloning the layers state from the higher level MapConfig component (at least for my proof-of-concept). So, if it's not that important, I say we stick with the next layer's id value.

Actually, you could just hard-code the titles. Anyway...

Good spotting, but I'm happy with the current approach for now.

@ccbblin ccbblin force-pushed the feat/quick-change-cycles-through-more-basemaps branch from d1d4bbf to 1685ec5 Compare August 26, 2025 21:41
@ccbblin ccbblin added this pull request to the merge queue Sep 4, 2025
Merged via the queue into master with commit 4bfba36 Sep 4, 2025
21 of 25 checks passed
@ccbblin ccbblin deleted the feat/quick-change-cycles-through-more-basemaps branch September 4, 2025 21:27
@linz-li-bot linz-li-bot mentioned this pull request Sep 4, 2025
@ccbblin ccbblin mentioned this pull request Sep 7, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 7, 2025
# [8.8.0](v8.7.0...v8.8.0)
(2025-09-07)


### Bug Fixes

* add required permissions for release please github action
([#3497](#3497))
([a6155c9](a6155c9))
* **cli-vector:** Fix the tmp path of download layers and add try catch.
BM-1352 ([#3494](#3494))
([3769175](3769175))
* intermittent unit tests
([#3503](#3503))
([1e942af](1e942af))
* stop using GITHUB_TOKEN for release-please
([#3495](#3495))
([198cb29](198cb29))


### Features

* **cli-raster:** Fetch chart imagery metadata from backup
location.BM-1345 ([#3492](#3492))
([2b42fa7](2b42fa7))
* **cli-raster:** New cli to standardise charts map. BM-1338
([#3483](#3483))
([35b7854](35b7854))
* **geo:** implement support for all raster topo map series projections
BM-1160 ([#3480](#3480))
([8652578](8652578))
* **geo:** support tile matrixes that are not square
([#3484](#3484))
([7720d02](7720d02))
* **lambda-tiler:** support one band uint16 lerc tiffs
([#3489](#3489))
([906d016](906d016))
* **landing:** quick change cycles through more basemaps BM-1293
([#3493](#3493))
([4bfba36](4bfba36))
@ccbblin ccbblin mentioned this pull request Sep 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2025
# [8.9.0](v8.7.0...v8.9.0)
(2025-09-09)


### Bug Fixes

* add required permissions for release please github action
([#3497](#3497))
([a6155c9](a6155c9))
* **cli-vector:** Fix the tmp path of download layers and add try catch.
BM-1352 ([#3494](#3494))
([3769175](3769175))
* **geo:** ensure all supported epsg codes have a projection
([#3508](#3508))
([23a9243](23a9243))
* intermittent unit tests
([#3503](#3503))
([1e942af](1e942af))
* remove release-please from prod deploy
([#3506](#3506))
([05b6f95](05b6f95))
* stop using GITHUB_TOKEN for release-please
([#3495](#3495))
([198cb29](198cb29))


### Features

* **cli-raster:** Fetch chart imagery metadata from backup
location.BM-1345 ([#3492](#3492))
([2b42fa7](2b42fa7))
* **cli-raster:** New cli to standardise charts map. BM-1338
([#3483](#3483))
([35b7854](35b7854))
* **geo:** implement support for all raster topo map series projections
BM-1160 ([#3480](#3480))
([8652578](8652578))
* **geo:** support tile matrixes that are not square
([#3484](#3484))
([7720d02](7720d02))
* **lambda-tiler:** support one band uint16 lerc tiffs
([#3489](#3489))
([906d016](906d016))
* **landing:** quick change cycles through more basemaps BM-1293
([#3493](#3493))
([4bfba36](4bfba36))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants