feat: split writing reviewer into zh and en jobs#11
Conversation
- review-writing-zh: Chinese files only, Chinese rules and report - review-writing-en: English files only, English rules and report - review-facts: covers both languages, unchanged - Each job skips gracefully if no files in its language are changed Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lipingtababa
left a comment
There was a problem hiding this comment.
Writing Reviewer Split: Informational Review
Good structural improvement — splitting the monolingual reviewer into language-specific jobs is the right call. A few observations:
What works well
- Graceful skip logic: Each job checks whether its language directory has changes and exits early if not. Clean approach.
- Language-appropriate output: The zh job produces a Chinese report with Chinese review criteria; the en job stays in English. This makes review comments actionable for contributors working in each language.
- Fact-checker refinement: Adding
fileto the output format template forreview-factsis a small but useful improvement now that it explicitly covers both directories.
Observations
-
Duplicated prompt structure: The zh and en prompts share identical review dimensions (AI fingerprint detection, terminology, logic, information density, structure, style) but are fully duplicated rather than templated. This is ~120 lines of parallel content that must be kept in sync manually. If the review criteria evolve (e.g., adding a new dimension), both prompts need updating. Worth considering whether a shared base prompt with language-specific overrides would be more maintainable — though the simplicity of full duplication has its own value for a file this size.
-
Sticky comment collision risk: Both
review-writing-zhandreview-writing-enuseuse_sticky_comment: true. Ifclaude-code-actionkeys sticky comments per workflow (not per job), one job's comment could overwrite the other's. Worth verifying the sticky comment keying behavior — if it collides, setting a distinctsticky_comment_idper job would fix it. -
Chinese AI fingerprint list is thorough: The zh prompt includes a well-curated list of Chinese AI writing fingerprints (corporate buzzwords like 赋能/闭环/抓手, structural patterns like symmetric parallel lists). This is more specific and useful than a generic "check for AI-sounding text" instruction.
-
Minor: The en prompt still contains the line "Space between CJK and Latin characters" (line ~101 area). Since this job only reviews
en/files, that rule is unlikely to trigger, but it's slightly misleading in an English-only context.
Verdict
Solid, focused change. The duplication and sticky-comment-key questions are the main things to keep an eye on.
Summary
review-writinginto two separate jobs:review-writing-zhandreview-writing-enreview-writing-zh: reviews onlyzh/files using Chinese-specific AI fingerprint rules, outputs a Chinese reportreview-writing-en: reviews onlyen/files using English-specific AI fingerprint rules, outputs an English reportreview-factsremains unchanged, covers both languagesTest plan
zh/changes — onlyreview-writing-zhproduces a substantive commenten/changes — onlyreview-writing-enproduces a substantive comment