fix for outdated file reference for excluding countries - #1461
Open
Nageshk88 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fixes #1377
The Development section of the README instructed users to remove
unwanted countries from
sass/_flag-icons-list.scss. That file nolonger stores the country list directly — it now just loops over the
$flag-icons-included-countriesvariable, which lives insass/_variables.scss.This means the instruction was inconsistent with the Usage section
above it, which already correctly points to
sass/_variables.scss.Change
Updated the Development section to reference
sass/_variables.scssand the
$flag-icons-included-countriesvariable instead of theoutdated
_flag-icons-list.scssfile, so both sections of the READMEnow agree.
Type of change
Checklist