Skip to content

[IPAM] Initialization #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Oct 28, 2024
Merged

[IPAM] Initialization #2790

adamjensenbot merged 1 commit into from
Oct 28, 2024

Conversation

@aleoli
Copy link
Member

@aleoli aleoli commented Oct 25, 2024 •
edited
Loading

Description

This pr adds the initialization functions for the new IPAM

@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Oct 25, 2024

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/ipam-initialize branch 2 times, most recently from e0002ce to e3c9c26 Compare October 28, 2024 09:58
@aleoli aleoli force-pushed the aol/ipam-initialize branch 3 times, most recently from 582476d to 06e21f6 Compare October 28, 2024 10:14
@aleoli aleoli requested review from cheina97 and fra98 October 28, 2024 10:21
@aleoli aleoli marked this pull request as ready for review October 28, 2024 10:21
fra98
fra98 reviewed Oct 28, 2024
View reviewed changes
@aleoli aleoli force-pushed the aol/ipam-initialize branch from 06e21f6 to 606b5c9 Compare October 28, 2024 15:45
@aleoli
Copy link
Member Author

aleoli commented Oct 28, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 28, 2024
@adamjensenbot adamjensenbot merged commit cefdab6 into liqotech:ipam Oct 28, 2024
9 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleoli @adamjensenbot @fra98