Skip to content

[Fix] argocd install #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Nov 19, 2024
Merged

[Fix] argocd install #2794

adamjensenbot merged 1 commit into from
Nov 19, 2024

Conversation

@aleoli
Copy link
Member

@aleoli aleoli commented Oct 29, 2024 •
edited
Loading

Description

This pr fixes the sync of liqo with argocd by removing the pre/post install/update helm hooks not correctly handled by argocd

@aleoli
Copy link
Member Author

aleoli commented Oct 29, 2024

/build

@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Oct 29, 2024

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Oct 31, 2024

/build

3 similar comments
@aleoli
Copy link
Member Author

aleoli commented Oct 31, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 31, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Oct 31, 2024

/build

@aleoli
Copy link
Member Author

aleoli commented Nov 5, 2024

/test

@aleoli aleoli marked this pull request as ready for review November 5, 2024 10:57
@aleoli aleoli requested review from cheina97 and fra98 November 5, 2024 10:58
fra98
fra98 reviewed Nov 7, 2024
View reviewed changes
fra98
fra98 approved these changes Nov 11, 2024
View reviewed changes
@aleoli
Copy link
Member Author

aleoli commented Nov 11, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Nov 18, 2024

/rebase test=true

@fra98
Copy link
Member

fra98 commented Nov 19, 2024

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Nov 19, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Nov 19, 2024
@adamjensenbot adamjensenbot merged commit acf7145 into liqotech:master Nov 19, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleoli @adamjensenbot @fra98