Skip to content

Conversation

@claudiolor
Copy link
Contributor

Description

When the Endpoint field of the status of the GatewayServer resource is empty, liqoctl info peer returned a nil pointer exception.
This PR fixes this issue.

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member

fra98 commented Nov 4, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the clo/fix-info-nil-pointer branch from 656df42 to 7bdca61 Compare November 4, 2024 10:45
@fra98
Copy link
Member

fra98 commented Nov 18, 2024

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the clo/fix-info-nil-pointer branch from 7bdca61 to aeb0cdf Compare November 18, 2024 13:47
@aleoli aleoli merged commit 22f77f2 into liqotech:master Nov 19, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants