Skip to content

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented Nov 21, 2024

Description

This PR fixes the liqoctl build on arch different from Linux, by avoiding importing the nftables library (known to be compatible only on Linux). In particular, the NetFirstAndLastIP() function is copied from the library into the Liqo source code (avoiding importing the library).

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98
Copy link
Member Author

fra98 commented Nov 21, 2024

/build

@fra98 fra98 merged commit c0db3e5 into liqotech:ipam Nov 22, 2024
11 checks passed
@fra98 fra98 deleted the frt/remove-nftables-lib branch November 22, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants