[IPAM] Core implementation #2828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/ipamcore
branch
from
bd3ae01 to
d0baa7d
Compare
Member
Author
|
/build |
cheina97
force-pushed
the
frc/ipamcore
branch
from
41299a9 to
10d7be6
Compare
Member
Author
|
/build |
fra98
changed the title
cheina97
force-pushed
the
frc/ipamcore
branch
2 times, most recently
from
7fb08dc to
cb3df8b
Compare
Member
Author
|
/build |
cheina97
force-pushed
the
frc/ipamcore
branch
from
cb3df8b to
3d28fbd
Compare
Member
Author
|
/build |
cheina97
force-pushed
the
frc/ipamcore
branch
from
3d28fbd to
9bad474
Compare
Member
Author
|
/build |
cheina97
force-pushed
the
frc/ipamcore
branch
2 times, most recently
from
090c495 to
802e9af
Compare
Member
Author
|
/build |
cheina97
force-pushed
the
frc/ipamcore
branch
12 times, most recently
from
f74cf3e to
02478f4
Compare
cheina97
force-pushed
the
frc/ipamcore
branch
from
949423d to
39a7e00
Compare
Member
Author
|
/build |
fra98
reviewed
Nov 28, 2024
cheina97
force-pushed
the
frc/ipamcore
branch
from
39a7e00 to
c0b8904
Compare
Member
Author
|
/build |
Member
Author
|
/test |
cheina97
force-pushed
the
frc/ipamcore
branch
3 times, most recently
from
87e2ec7 to
a0935de
Compare
Member
Author
|
/rebase test=true |
cheina97
force-pushed
the
frc/ipamcore
branch
from
a0935de to
bec8fdb
Compare
Member
Author
|
/test |
fra98
reviewed
Nov 28, 2024
cheina97
force-pushed
the
frc/ipamcore
branch
from
bec8fdb to
29f2027
Compare
Member
Author
|
/build |
1 similar comment
Member
Author
|
/build |
cheina97
force-pushed
the
frc/ipamcore
branch
from
e0768a4 to
5d7d658
Compare
claudiolor
reviewed
Nov 29, 2024
aleoli
reviewed
Nov 29, 2024
Member
aleoli
left a comment
aleoli
left a comment
There was a problem hiding this comment.
In general, I would add some comments on how the algorithm works and the single functions work in the core package
Member
Author
|
/rebase test=true |
1 similar comment
Member
Author
|
/rebase test=true |
cheina97
force-pushed
the
frc/ipamcore
branch
from
5bb369a to
c68bd94
Compare
cheina97
force-pushed
the
frc/ipamcore
branch
from
c68bd94 to
7c3bd29
Compare
Member
Author
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the new liqo ipam core
It's main features are:
The IPAM is managed internally using a binary tree, where each node is a network and contains a list of IPs
We used this algorithm https://en.wikipedia.org/wiki/Buddy_memory_allocation to optimize the network allocation