Skip to content

Add global labels and annotations to liqo-created resources #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Dec 5, 2024
Merged

Add global labels and annotations to liqo-created resources #2832

adamjensenbot merged 1 commit into from
Dec 5, 2024

Conversation

@aleoli
Copy link
Member

@aleoli aleoli commented Nov 25, 2024 •
edited
Loading

Description

This pr adds global labels and annotations to all liqo-created resources.

It can be useful to add the resources created by liqo controllers to an argocd application

@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Nov 25, 2024

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/resource-labels branch from 6441c75 to 1a8edc2 Compare November 25, 2024 13:48
@aleoli
Copy link
Member Author

aleoli commented Nov 25, 2024

/build

@aleoli aleoli force-pushed the aol/resource-labels branch from 1a8edc2 to 531ac5e Compare November 25, 2024 15:37
@aleoli
Copy link
Member Author

aleoli commented Nov 25, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Nov 26, 2024

/build

@aleoli aleoli changed the title Add global labels to liqo-created resources Add global labels and annotations to liqo-created resources Nov 26, 2024
@aleoli
Copy link
Member Author

aleoli commented Nov 26, 2024

/build

@aleoli aleoli force-pushed the aol/resource-labels branch from 409427c to a26279b Compare November 26, 2024 11:03
@aleoli
Copy link
Member Author

aleoli commented Nov 26, 2024

/test

@aleoli aleoli marked this pull request as ready for review November 26, 2024 13:40
fra98
fra98 reviewed Dec 3, 2024
View reviewed changes
@aleoli aleoli force-pushed the aol/resource-labels branch from ef6b003 to 61670e4 Compare December 5, 2024 14:51
@aleoli
Copy link
Member Author

aleoli commented Dec 5, 2024

/test

@aleoli
Copy link
Member Author

aleoli commented Dec 5, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 5, 2024
@adamjensenbot adamjensenbot merged commit d150b75 into liqotech:master Dec 5, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiolor claudiolor claudiolor approved these changes

@fra98 fra98 fra98 approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleoli @adamjensenbot @claudiolor @fra98