Skip to content

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented Nov 26, 2024

Description

This PR modifies the liqo-controller-manager to wait for the connection to the IPAM server to be Ready before setting up the modules and starting controllers.

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/wait-ipam-server-ready branch from 29a6925 to 9dad584 Compare November 26, 2024 13:40
@fra98 fra98 force-pushed the frt/wait-ipam-server-ready branch from 9dad584 to ef0a970 Compare November 26, 2024 13:44
@fra98 fra98 merged commit 3a039b2 into liqotech:ipam Nov 26, 2024
9 checks passed
@fra98 fra98 deleted the frt/wait-ipam-server-ready branch November 26, 2024 13:55
@fra98 fra98 added the kind/bug label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants