Skip to content

Conversation

@fra98
Copy link
Member

@fra98 fra98 commented Nov 29, 2024

Description

This PR fixes the uninstall with the new IPAM.
In particular, it sets a specific annotation to networks installed with Helm. Since these are required through the whole lifecycle of Liqo, we do not add a finalizer since we do not need to unmap them (as we are uninstalling anyway).

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/ipam-uninstall branch 3 times, most recently from b162420 to 5444567 Compare December 2, 2024 10:17
@fra98
Copy link
Member Author

fra98 commented Dec 2, 2024

/test

@fra98 fra98 force-pushed the frt/ipam-uninstall branch from ea97492 to c87f9bd Compare December 3, 2024 11:41
@fra98 fra98 merged commit f5c494f into liqotech:ipam Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants