Skip to content

[IPAM] function NetworkIsAvailable refactoring #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Dec 4, 2024
Merged

[IPAM] function NetworkIsAvailable refactoring #2841

adamjensenbot merged 1 commit into from
Dec 4, 2024

Conversation

@cheina97
Copy link
Member

@cheina97 cheina97 commented Dec 4, 2024

Description

This PR changes how the NetworkIsAvailable internally work

@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Dec 4, 2024

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

cheina97 commented Dec 4, 2024

/hold

@cheina97
Copy link
Member Author

cheina97 commented Dec 4, 2024

/build

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Dec 4, 2024
@cheina97
Copy link
Member Author

cheina97 commented Dec 4, 2024

/build

@cheina97
Copy link
Member Author

cheina97 commented Dec 4, 2024

/unhold

@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Dec 4, 2024
claudiolor
claudiolor reviewed Dec 4, 2024
View reviewed changes
fra98
fra98 approved these changes Dec 4, 2024
View reviewed changes
@cheina97
Copy link
Member Author

cheina97 commented Dec 4, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 4, 2024
@adamjensenbot adamjensenbot merged commit f7c2de7 into liqotech:ipam Dec 4, 2024
9 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 4, 2024
@cheina97 cheina97 deleted the frc/fixipam branch March 5, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiolor claudiolor claudiolor left review comments

@fra98 fra98 fra98 approved these changes

@aleoli aleoli Awaiting requested review from aleoli

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cheina97 @adamjensenbot @claudiolor @fra98