Skip to content

Conversation

@cheina97
Copy link
Member

Description

This pr adds the value control-planes inside the np-nodes flag in liqoctl test network

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 force-pushed the frc/networktestmasternodes branch 2 times, most recently from fe771d2 to 3dce836 Compare December 12, 2024 18:09
@cheina97
Copy link
Member Author

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the frc/networktestmasternodes branch from 3dce836 to 945cb49 Compare December 12, 2024 18:10
@fra98
Copy link
Member

fra98 commented Dec 16, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Dec 16, 2024
@adamjensenbot adamjensenbot merged commit 7e265cb into liqotech:master Dec 16, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Dec 16, 2024
@cheina97 cheina97 deleted the frc/networktestmasternodes branch March 5, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants