Skip to content

Conversation

@aleoli
Copy link
Member

@aleoli aleoli commented Apr 29, 2025

Description

This pr fixes the permissions granted to the peering user when performing an in-band peering

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Apr 29, 2025
@aleoli aleoli marked this pull request as ready for review April 29, 2025 13:08
@aleoli
Copy link
Member Author

aleoli commented Apr 29, 2025

/test

@github-actions github-actions bot added the docs Updates or adds documentation label Apr 29, 2025
@aleoli aleoli force-pushed the aol/fix-in-band-permission branch from ccf7ecd to 1d88564 Compare April 29, 2025 13:31
@aleoli
Copy link
Member Author

aleoli commented Apr 29, 2025

/test

@aleoli
Copy link
Member Author

aleoli commented Apr 29, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Apr 29, 2025
@adamjensenbot adamjensenbot merged commit 006c343 into liqotech:master Apr 29, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Updates or adds documentation fix Fixes a bug in the codebase. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants