Skip to content

[Telemetry] UUID #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
May 12, 2025
Merged

[Telemetry] UUID #3039

adamjensenbot merged 1 commit into from
May 12, 2025

Conversation

@cheina97
Copy link
Member

@cheina97 cheina97 commented May 7, 2025

Description

This PR allows telemetry job to generate a UUID to use as ClusterID
This increases the privacy and avoid cases in which 2 clusters have been set with the same ClusterID

@adamjensenbot
Copy link
Collaborator

adamjensenbot commented May 7, 2025

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label May 7, 2025
@cheina97 cheina97 force-pushed the frc/telemetryid branch 3 times, most recently from 71b1d53 to 144bb97 Compare May 8, 2025 11:24
aleoli
aleoli approved these changes May 9, 2025
View reviewed changes
@cheina97
Copy link
Member Author

cheina97 commented May 9, 2025

/build

@cheina97 cheina97 force-pushed the frc/telemetryid branch 2 times, most recently from 0b15391 to 9d0bb26 Compare May 9, 2025 10:20
@cheina97
Copy link
Member Author

cheina97 commented May 9, 2025

/build

@cheina97 cheina97 force-pushed the frc/telemetryid branch 2 times, most recently from a772639 to 28ff263 Compare May 9, 2025 10:37
@cheina97
Copy link
Member Author

cheina97 commented May 9, 2025

/build

@cheina97 cheina97 force-pushed the frc/telemetryid branch from 28ff263 to 2189dd7 Compare May 9, 2025 10:46
@cheina97 cheina97 force-pushed the frc/telemetryid branch from 2189dd7 to bf109c1 Compare May 9, 2025 10:47
@cheina97
Copy link
Member Author

cheina97 commented May 9, 2025

/build

@cheina97
Copy link
Member Author

cheina97 commented May 9, 2025

/rebase test=true

1 similar comment
@cheina97
Copy link
Member Author

cheina97 commented May 12, 2025

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented May 12, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 12, 2025
@adamjensenbot adamjensenbot merged commit 7e45163 into liqotech:master May 12, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 12, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleoli aleoli aleoli approved these changes

Assignees

No one assigned

Labels

fix Fixes a bug in the codebase. size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cheina97 @adamjensenbot @aleoli