Skip to content

Conversation

@likakuli
Copy link
Contributor

@likakuli likakuli commented May 14, 2025

Description

return the real error when to update local pod status. this is a clearly visible bug

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

@adamjensenbot
Copy link
Collaborator

Hi @likakuli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label May 14, 2025
@cheina97
Copy link
Member

Hi @likakuli, thanks for your PR. Yes it is a bug indeed.

@cheina97
Copy link
Member

/rebase test=true

@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label May 19, 2025
@adamjensenbot adamjensenbot merged commit d6d36ab into liqotech:master May 19, 2025
15 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug in the codebase. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants