Skip to content

Conversation

@laurall974
Copy link

Description

The resource slice was missing required labels, which caused issues when trying to create resource slices in a declarative way.

@adamjensenbot
Copy link
Collaborator

Hi @laurall974. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the docs Updates or adds documentation label May 23, 2025
@fra98
Copy link
Member

fra98 commented May 23, 2025

Thanks for your contribution

@fra98
Copy link
Member

fra98 commented May 23, 2025

Fix #3046

@fra98
Copy link
Member

fra98 commented May 26, 2025

/rebase test=true

Copy link
Member

@frisso frisso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, Laura!

@cheina97 cheina97 merged commit d3b4971 into liqotech:master May 27, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Updates or adds documentation size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants