fix: escape the shadowpod creator label #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
claudiolor
force-pushed
the
clo/fix-creator-label
branch
3 times, most recently
from
f415031 to
d91633b
Compare
Contributor
Author
|
/build |
Contributor
Author
|
/rebase test=true |
When a token of a service account is used as identity for a virtual node, the creation of a shadowpod fails due to the `liqo.io/creator-user` which contains a string like the following, when the token of a SA is used: "system:serviceaccount:liqo-tenant-cl01:user01". This PR make sure that the string is escaped before being written in the label field.
adamjensenbot
force-pushed
the
clo/fix-creator-label
branch
from
d91633b to
c84aac6
Compare
fra98
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a token of a service account is used as identity for a virtual node, the creation of a shadowpod fails due to the
liqo.io/creator-userwhich contains a string like the following, when the token of a SA is used:"system:serviceaccount:liqo-tenant-cl01:user01". This PR makes sure that the string is escaped before being written in the label field.