Skip to content

[Auth] Tenant idempotency fix #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Jul 11, 2025
Merged

[Auth] Tenant idempotency fix #3061

adamjensenbot merged 1 commit into from
Jul 11, 2025

Conversation

@cheina97
Copy link
Member

@cheina97 cheina97 commented Jun 25, 2025

Description

This PR fixes a bug that causes liqoctl auth commands to not be idempotent on tenant resources.

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Jun 25, 2025
@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Jun 25, 2025

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@cheina97 cheina97 changed the title fix: tenant spec idempotency [Auth] Tenant idempotency fix Jun 25, 2025
@cheina97 cheina97 force-pushed the frc/authfix branch 2 times, most recently from f282a36 to f57f8c2 Compare June 26, 2025 09:56
@cheina97
Copy link
Member Author

cheina97 commented Jun 26, 2025

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jun 26, 2025

/rebase test=true

2 similar comments
@cheina97
Copy link
Member Author

cheina97 commented Jun 27, 2025

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jun 30, 2025

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jul 7, 2025

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Jul 11, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jul 11, 2025
@adamjensenbot adamjensenbot merged commit fa92097 into liqotech:master Jul 11, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jul 11, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleoli aleoli aleoli approved these changes

Assignees

No one assigned

Labels

fix Fixes a bug in the codebase. size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cheina97 @adamjensenbot @aleoli