Skip to content

Conversation

@cheina97
Copy link
Member

@cheina97 cheina97 commented Jul 11, 2025

This PR fixes a huge bug we had in CIDR remapping. The SNAT rules for the pod-cidr and ext-cidr inside the gateway were populated with the wrong CIDRs.

Why wasn’t the bug spotted after a year and a half? Because when we perform remapping tests, we typically set the same pod CIDR and external CIDR on every cluster. In this particular case, the bug doesn’t occur because, in a similar scenario, the local pod CIDR and the remote CIDR (not the remapped one) are equal.

Should we consider changing the CIDR used in E2E tests to enhance entropy?

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Jul 11, 2025
@cheina97
Copy link
Member Author

/rebase test=true

@fra98
Copy link
Member

fra98 commented Jul 14, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jul 14, 2025
@adamjensenbot adamjensenbot merged commit 7228d38 into liqotech:master Jul 14, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jul 14, 2025
@cheina97 cheina97 deleted the frc/remapfix branch July 14, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug in the codebase. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants