[Network] fix SNAT remaping CIDR #3064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a huge bug we had in CIDR remapping. The SNAT rules for the pod-cidr and ext-cidr inside the gateway were populated with the wrong CIDRs.
Why wasn’t the bug spotted after a year and a half? Because when we perform remapping tests, we typically set the same pod CIDR and external CIDR on every cluster. In this particular case, the bug doesn’t occur because, in a similar scenario, the local pod CIDR and the remote CIDR (not the remapped one) are equal.
Should we consider changing the CIDR used in E2E tests to enhance entropy?