Skip to content

[Controller-Manager] flags refactoring #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Aug 29, 2025
Merged

[Controller-Manager] flags refactoring #3088

adamjensenbot merged 1 commit into from
Aug 29, 2025

Conversation

@cheina97
Copy link
Member

@cheina97 cheina97 commented Jul 25, 2025 •
edited
Loading

Description

This PR refactors how the flags in controller manager are used, to improve readability

@cheina97 cheina97 marked this pull request as draft July 25, 2025 14:56
@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Jul 25, 2025

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the refactor Reorganizes or optimizes code without changing its behavior label Jul 25, 2025
@cheina97
Copy link
Member Author

cheina97 commented Jul 25, 2025

/rebase test=true

@cheina97 cheina97 force-pushed the frc/flagrefactor branch 3 times, most recently from 11fc981 to dd57f04 Compare July 25, 2025 18:01
@cheina97
Copy link
Member Author

cheina97 commented Jul 25, 2025

/rebase test=true

@cheina97 cheina97 marked this pull request as ready for review July 28, 2025 07:38
@aleoli
Copy link
Member

aleoli commented Aug 29, 2025

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Aug 29, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 29, 2025
@adamjensenbot adamjensenbot merged commit 0195d74 into liqotech:master Aug 29, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleoli aleoli aleoli approved these changes

Assignees

No one assigned

Labels

refactor Reorganizes or optimizes code without changing its behavior size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cheina97 @adamjensenbot @aleoli