Skip to content

Conversation

@Deblazz
Copy link

@Deblazz Deblazz commented Aug 10, 2025

Description

Added a sleep between clusters creation in setup.sh, since otherwise the second one would fail due to a timeout.

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Aug 10, 2025
@adamjensenbot
Copy link
Collaborator

Hi @Deblazz. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@claudiolor
Copy link
Contributor

Hi @Deblazz, thanks for this contribution!
I tried to reproduce the issue you reported but the Kind clusters were correctly created.

I'm not sure about the reason why you are adding a sleep between the two cluster creations, as the kind create command returns once the cluster is created and each cluster has its own independent docker containers.
I would instead investigate the real reason why Kind is failing during the creation of the second cluster, and if there is something to wait, we need to understand what needs to be waited, as I believe 15 seconds is an arbitrary value, which might not fit all the cases.

I will close this PR, but feel free to open a new one once you find a solution :)

@claudiolor claudiolor closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug in the codebase. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants