Skip to content

fix(reflection): handle errors when getting metadata accessor #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamjensenbot merged 1 commit into from
Aug 27, 2025
Merged

fix(reflection): handle errors when getting metadata accessor #3106

adamjensenbot merged 1 commit into from
Aug 27, 2025

Conversation

@aleoli
Copy link
Member

@aleoli aleoli commented Aug 19, 2025 •
edited
Loading

Description

This pr fixes a panic in the Liqo reflectors when on high load

Fix #3105

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Aug 19, 2025
@adamjensenbot
Copy link
Collaborator

adamjensenbot commented Aug 19, 2025

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@aleoli
Copy link
Member Author

aleoli commented Aug 19, 2025

/test

@github-actions github-actions bot added the refactor Reorganizes or optimizes code without changing its behavior label Aug 19, 2025
@aleoli
Copy link
Member Author

aleoli commented Aug 19, 2025

/test

@aleoli aleoli force-pushed the aol/fix-reflector-panic branch from 85d57a0 to 16bf740 Compare August 19, 2025 08:36
@github-actions github-actions bot removed the refactor Reorganizes or optimizes code without changing its behavior label Aug 19, 2025
@aleoli
Copy link
Member Author

aleoli commented Aug 25, 2025

/test

1 similar comment
@aleoli
Copy link
Member Author

aleoli commented Aug 26, 2025

/test

@aleoli aleoli marked this pull request as ready for review August 26, 2025 08:57
@aleoli
Copy link
Member Author

aleoli commented Aug 27, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 27, 2025
@adamjensenbot adamjensenbot merged commit f812641 into liqotech:master Aug 27, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 27, 2025
@aleoli aleoli mentioned this pull request Aug 27, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheina97 cheina97 cheina97 approved these changes

@fra98 fra98 fra98 approved these changes

Assignees

No one assigned

Labels

fix Fixes a bug in the codebase. size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

panic="object does not implement the Object interfaces"

4 participants

@aleoli @adamjensenbot @cheina97 @fra98