feat: allow registering a referral through the proxy#21
Open
feat: allow registering a referral through the proxy#21
Conversation
LIQ-1040 Liquality Proxy - Register Referral
Background:
Problem:
Proposal:
|
koderholic
requested changes
Jun 22, 2022
Comment on lines
+30
to
+31
| // handle referrals | ||
| Referral memory referral = referralRegistry.getReferral(user); |
Collaborator
There was a problem hiding this comment.
I don't think referralRegistry was ever initialized, at what point did you equate referralRegistry to the Referral smart contract address?
trafico-bot
bot
added
⚠️ Changes requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LIQ-1040