Code review and refactor#33
Open
mikeschinkel wants to merge 4 commits into
Open
Conversation
In the initial refactor commit I had not wired up the category and global flags, and after discussion with @mcred decided to move commands into a subdirectory.
Added a missing error handled in lpm.Initialize() and renamed lpm.ContextFromCobraCommand() to lpm.GetContextFromCommand().
Changed WorkingDir, Category, HomeDir and Path to all be private as they are not used anywhere outside of Context and I didn't want Context to less cohesive than it needs to be. Also renamed GetFilteredPackages() to GetCategoryFilteredPackages() to be more accurate.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised, here is a PR to your
feature/idiomatic-gobranch from the fork I created and worked on. For your review and consideration.