Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capi bump to v1.9.x #318

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat: capi bump to v1.9.x #318

merged 1 commit into from
Feb 28, 2025

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Feb 12, 2025

What this PR does / why we need it:

Bump CAPI to v1.9.x

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #312

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@richardcase richardcase added the kind/feature New feature or request label Feb 12, 2025
@richardcase richardcase requested a review from Copilot February 12, 2025 08:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • go.mod: Language not supported
  • internal/scope/machine.go: Evaluated as low risk
  • api/v1alpha1/microvmmachine_webhook.go: Evaluated as low risk
  • api/v1alpha1/microvmmachinetemplate_webhook.go: Evaluated as low risk
  • test/e2e/utils/utils.go: Evaluated as low risk
  • api/v1alpha1/microvmcluster_webhook.go: Evaluated as low risk
  • controllers/microvmmachine_controller.go: Evaluated as low risk
  • internal/scope/machine_test.go: Evaluated as low risk
Comments suppressed due to low confidence (2)

test/e2e/utils/clusterctl.go:26

  • [nitpick] The variable name 'i' is ambiguous. It should be renamed to 'index'.
for i, o := range template {

test/e2e/utils/clusterctl.go:78

  • Ensure that the new behavior introduced by 'clusterctl.ApplyCustomClusterTemplateAndWait' is covered by tests.
clusterctl.ApplyCustomClusterTemplateAndWait(ctx, clusterctl.ApplyCustomClusterTemplateAndWaitInput{
@richardcase richardcase force-pushed the capi_bump branch 4 times, most recently from 800093c to ccc2304 Compare February 17, 2025 15:28
@richardcase richardcase changed the title wip: capi bump to v1.9.x feat: capi bump to v1.9.x Feb 17, 2025
This bumps CAPI to v1.9.4 and associated packages.

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase marked this pull request as ready for review February 17, 2025 15:31
Copy link
Member

@steve-fraser steve-fraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardcase richardcase merged commit 3f33ad4 into main Feb 28, 2025
7 checks passed
@richardcase richardcase deleted the capi_bump branch February 28, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to the latest CAPI version
2 participants