-
Notifications
You must be signed in to change notification settings - Fork 59
adding pci devices support for flintlockd #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for flintlock-docs canceled.
|
|
|
||
| message PCIDevice { | ||
| string VendorID = 1; | ||
| string DeviceID = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably model this for future expansion. For example, selecting a GPU for a pool of GPUs on the host.
Something along the lines of what we do with VolumeSource.
Maybe we have something like:
message PCIDevice {
optional DeviceIDSource = 1;
}Another option is that we model it on "requests". So the VM requests a PCI device that meets a set of criteria? And may the criteria is a CEL expression which would then cover a number of different options one being by DeviceID? I quite like this approach, its very similar to where Kubernetes is going
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we used the CEL approach then it could end up being:
message PCIDevice {
string Expression = 1;
}
And then the expression would be something like:
device.id == "58:00.0"device.class == "vga" && device.available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could then also use CEL to select PCI devices available to flintlock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an interesting idea. How would you validate the cell expression?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need a custom data model for the CEL side and populate that with data from /sys/bus/pci/devices and other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could go with something like this to not block using the device id directly?:
message PCIDevice {
optional DeviceIDSource = 1;
optional Expression= 2; // Add this later
}|
This PR is stale because it has been open 60 days with no activity. |
Adding PCI devices support for Filntlockd