Skip to content

[Contracts] Address redemption helper audit feedback #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielattilasimon merged 2 commits into from
Oct 31, 2025
Merged

[Contracts] Address redemption helper audit feedback #1167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e4652
fix: remove unnecessary infinite approval
danielattilasimon Oct 29, 2025
20b871b
fix: explicitly require non-zero amount
danielattilasimon Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions contracts/src/RedemptionHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ contract RedemptionHelper is IRedemptionHelper {
require(_collateralRegistry.getTroveManager(i) == _addresses[i].troveManager(), "TroveManager mismatch");
addresses.push(_addresses[i]);
}

boldToken.approve(address(_collateralRegistry), type(uint256).max);
}

// Meant to be called off-chain
Expand Down Expand Up @@ -148,6 +146,7 @@ contract RedemptionHelper is IRedemptionHelper {
uint256 _maxFeePct,
uint256[] memory _minCollRedeemed
) external {
require(_bold > 0, "Redeemed amount must be non-zero");
require(_minCollRedeemed.length == numBranches, "Wrong _minCollRedeemed length");

RedemptionContext[] memory branch = new RedemptionContext[](numBranches);
Expand Down