Skip to content

fix: resolve eslint/neostandard peer dependency conflict breaking CI#85

Merged
github-actions[bot] merged 3 commits intomainfrom
copilot/fix-breaking-ci-issues
Mar 1, 2026
Merged

fix: resolve eslint/neostandard peer dependency conflict breaking CI#85
github-actions[bot] merged 3 commits intomainfrom
copilot/fix-breaking-ci-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 1, 2026

npm ci fails due to eslint@^10.0.0 conflicting with neostandard@^0.12.2, which requires eslint@^9.0.0 as a peer dependency. The latest neostandard release (0.13.0) still only supports eslint@^9.0.0, so downgrading eslint is the correct resolution.

Changes

  • package.json: Downgrade eslint devDependency from ^10.0.0^9.0.0
  • package-lock.json: Regenerated to reflect the compatible eslint v9 resolution
  • .github/dependabot.yml: Added ignore rule for eslint major-version upgrades so Dependabot will not propose bumping to v10 until neostandard adds support for it
Original prompt

This section details on the original issue you should resolve

<issue_title>🐛 Bug: fix breaking CI issues</issue_title>
<issue_description>### Bug Report Checklist

Expected

CI currently breaks:

Run npm ci
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: neostandard@0.12.2
npm error Found: eslint@10.0.1
npm error node_modules/eslint
npm error   dev eslint@"^10.0.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.9.1
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.9.1" from @typescript-eslint/utils@8.55.0
npm error     node_modules/@stylistic/eslint-plugin/node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"^8.13.0" from @stylistic/eslint-plugin@2.11.0
npm error       node_modules/@stylistic/eslint-plugin
npm error         @stylistic/eslint-plugin@"2.11.0" from neostandard@0.12.2
npm error         node_modules/neostandard
npm error     @eslint-community/eslint-utils@"^4.8.0" from eslint@10.0.1
npm error     4 more (eslint-plugin-es-x, eslint-plugin-n, ...)
npm error   5 more (@stylistic/eslint-plugin, eslint-compat-utils, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^9.0.0" from neostandard@0.12.2
npm error node_modules/neostandard
npm error   dev neostandard@"^0.12.2" from the root project
npm error
npm error Conflicting peer dependency: eslint@9.39.3
npm error node_modules/eslint
npm error   peer eslint@"^9.0.0" from neostandard@0.12.2
npm error   node_modules/neostandard
npm error     dev neostandard@"^0.12.2" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

Actual

n/a

Additional Info

No response</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@lirantal lirantal marked this pull request as ready for review March 1, 2026 18:21
@lirantal lirantal self-requested a review as a code owner March 1, 2026 18:21
Copilot AI changed the title [WIP] Fix breaking CI issues due to dependency resolution fix: resolve eslint/neostandard peer dependency conflict breaking CI Mar 1, 2026
@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Fix CI dependency conflict by downgrading eslint

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Downgrade eslint from ^10.0.0 to ^9.0.0
• Resolves peer dependency conflict with neostandard@^0.12.2
• Fixes breaking CI dependency resolution errors
Diagram
flowchart LR
  A["eslint ^10.0.0"] -->|downgrade| B["eslint ^9.0.0"]
  B -->|compatible with| C["neostandard ^0.12.2"]
  C -->|resolves| D["CI passes"]
Loading

Grey Divider

File Changes

1. package.json 🐞 Bug fix +1/-1

Downgrade eslint to resolve dependency conflict

• Changed eslint devDependency version from ^10.0.0 to ^9.0.0
• Resolves npm peer dependency conflict with neostandard@^0.12.2
• Allows npm ci to succeed without --force or --legacy-peer-deps flags

package.json


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Mar 1, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 1, 2026

Open in StackBlitz

npm i https://pkg.pr.new/agent-rules@85

commit: 210ee39

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.34%. Comparing base (942c95c) to head (f08d2d1).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files           9        9           
  Lines        1628     1628           
  Branches       96       96           
=======================================
  Hits         1308     1308           
  Misses        314      314           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lirantal
Copy link
Copy Markdown
Owner

lirantal commented Mar 1, 2026

@copilot ok fine I get the idea to downgrade but how about you do a more thorough check for the neostandard package that conflicts, maybe there's a newer version of that which complies with the eslint v10 major version?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 1, 2026

@copilot ok fine I get the idea to downgrade but how about you do a more thorough check for the neostandard package that conflicts, maybe there's a newer version of that which compli...

Checked — the latest neostandard release is 0.13.0 and it still declares eslint@"^9.0.0" as its peer dependency. There's no published version of neostandard that supports eslint v10 yet, so downgrading eslint to ^9.0.0 is the only viable fix at this time.

@lirantal
Copy link
Copy Markdown
Owner

lirantal commented Mar 1, 2026

@copilot ok fine I get the idea to downgrade but how about you do a more thorough check for the neostandard package that conflicts, maybe there's a newer version of that which compli...

Checked — the latest neostandard release is 0.13.0 and it still declares eslint@"^9.0.0" as its peer dependency. There's no published version of neostandard that supports eslint v10 yet, so downgrading eslint to ^9.0.0 is the only viable fix at this time.

@copilot ok thanks for checking. should we somehow pin the versions to let dependabot know that it shouldn't suggest new upgrades to eslint v10 ?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 1, 2026

@copilot ok fine I get the idea to downgrade but how about you do a more thorough check for the neostandard package that conflicts, maybe there's a newer version of that which co...

Added an ignore rule for eslint major-version bumps in .github/dependabot.yml (commit f08d2d1). Dependabot will still propose minor/patch updates within v9, but won't open a PR to jump to v10 until neostandard adds support for it.

Copilot AI and others added 3 commits March 1, 2026 18:44
…eer dependency conflict

Co-authored-by: lirantal <316371+lirantal@users.noreply.github.com>
…andard supports v10

Co-authored-by: lirantal <316371+lirantal@users.noreply.github.com>
@github-actions github-actions bot force-pushed the copilot/fix-breaking-ci-issues branch from f08d2d1 to 3e1807a Compare March 1, 2026 18:44
@github-actions github-actions bot merged commit 0374175 into main Mar 1, 2026
@github-actions github-actions bot removed the automerge label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: fix breaking CI issues

3 participants