fix: resolve eslint/neostandard peer dependency conflict breaking CI#85
Conversation
Review Summary by QodoFix CI dependency conflict by downgrading eslint
WalkthroughsDescription• Downgrade eslint from ^10.0.0 to ^9.0.0 • Resolves peer dependency conflict with neostandard@^0.12.2 • Fixes breaking CI dependency resolution errors Diagramflowchart LR
A["eslint ^10.0.0"] -->|downgrade| B["eslint ^9.0.0"]
B -->|compatible with| C["neostandard ^0.12.2"]
C -->|resolves| D["CI passes"]
File Changes1. package.json
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 9 9
Lines 1628 1628
Branches 96 96
=======================================
Hits 1308 1308
Misses 314 314
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot ok fine I get the idea to downgrade but how about you do a more thorough check for the neostandard package that conflicts, maybe there's a newer version of that which complies with the eslint v10 major version? |
Checked — the latest |
@copilot ok thanks for checking. should we somehow pin the versions to let dependabot know that it shouldn't suggest new upgrades to eslint v10 ? |
Added an |
…eer dependency conflict Co-authored-by: lirantal <316371+lirantal@users.noreply.github.com>
…andard supports v10 Co-authored-by: lirantal <316371+lirantal@users.noreply.github.com>
f08d2d1 to
3e1807a
Compare
npm cifails due toeslint@^10.0.0conflicting withneostandard@^0.12.2, which requireseslint@^9.0.0as a peer dependency. The latestneostandardrelease (0.13.0) still only supportseslint@^9.0.0, so downgradingeslintis the correct resolution.Changes
package.json: DowngradeeslintdevDependency from^10.0.0→^9.0.0package-lock.json: Regenerated to reflect the compatible eslint v9 resolution.github/dependabot.yml: Addedignorerule foreslintmajor-version upgrades so Dependabot will not propose bumping to v10 untilneostandardadds support for itOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.