fix installer schema error messages - #736
Merged
Merged
Conversation
tomasecastro
added a commit
to tomasecastro/daloradius
that referenced
this pull request
Aug 6, 2026
fix installer schema error messages (lirantal#736)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #722 split dictionary data into a dedicated SQL file and updated the installer import order, but the two corresponding failure messages were accidentally reversed. This follow-up was found while triaging #734.
The change is diagnostic only: it does not alter schema contents, import order, installer control flow, or PHP behavior.
Validation
bash -n setup/install.shgit diff --check HEAD^ HEADSummary by cubic
Fixes swapped installer error messages during MariaDB schema loading: base schema and dictionary SQL import failures now report under the correct labels. Diagnostic-only; no changes to schema contents, import order, or installer behavior.
Written for commit 05b20f0. Summary will update on new commits.