Skip to content

fix installer schema error messages - #736

Merged
lirantal merged 1 commit into
masterfrom
work/fix-installer-schema-messages
Aug 5, 2026
Merged

fix installer schema error messages#736
lirantal merged 1 commit into
masterfrom
work/fix-installer-schema-messages

Conversation

@lirantal

@lirantal lirantal commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • report a base-schema import failure as a base-schema error
  • report a dictionary import failure as a dictionary error

Why

PR #722 split dictionary data into a dedicated SQL file and updated the installer import order, but the two corresponding failure messages were accidentally reversed. This follow-up was found while triaging #734.

The change is diagnostic only: it does not alter schema contents, import order, installer control flow, or PHP behavior.

Validation

  • reproduced the mismatch with a targeted shell assertion before the change
  • confirmed the same assertion passes after the change
  • bash -n setup/install.sh
  • git diff --check HEAD^ HEAD

Summary by cubic

Fixes swapped installer error messages during MariaDB schema loading: base schema and dictionary SQL import failures now report under the correct labels. Diagnostic-only; no changes to schema contents, import order, or installer behavior.

Written for commit 05b20f0. Summary will update on new commits.

Review in cubic

@lirantal lirantal self-assigned this Aug 5, 2026
@lirantal
lirantal requested a lite review from Copilot and removed request for Copilot August 5, 2026 19:01
@lirantal
lirantal marked this pull request as ready for review August 5, 2026 19:02

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@lirantal
lirantal merged commit 9b5b078 into master Aug 5, 2026
2 checks passed
tomasecastro added a commit to tomasecastro/daloradius that referenced this pull request Aug 6, 2026
fix installer schema error messages (lirantal#736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant