Skip to content

fix: resolve eslint peer dependency conflict breaking npm ci#149

Merged
lirantal merged 2 commits intomainfrom
copilot/debug-ci-dependency-install
Feb 21, 2026
Merged

fix: resolve eslint peer dependency conflict breaking npm ci#149
lirantal merged 2 commits intomainfrom
copilot/debug-ci-dependency-install

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

User description

eslint@^10.0.0 in devDependencies conflicts with neostandard@^0.12.1, which requires eslint@^9.0.0 as a peer dependency — causing npm ci to fail with ERESOLVE on every CI run.

Changes

  • package.json: downgrade eslint from ^10.0.0^9.0.0
  • package-lock.json: regenerated to reflect the resolved dependency tree

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.


PR Type

Bug fix


Description

  • Downgrade eslint from ^10.0.0 to ^9.0.0

  • Resolve peer dependency conflict with neostandard

  • Fix npm ci failures caused by ERESOLVE errors

  • Regenerate package-lock.json with resolved dependencies


Diagram Walkthrough

flowchart LR
  A["eslint@^10.0.0"] -->|conflicts with| B["neostandard@^0.12.1<br/>requires eslint@^9.0.0"]
  B -->|causes| C["npm ci ERESOLVE error"]
  D["Downgrade to<br/>eslint@^9.0.0"] -->|resolves| C
  D -->|satisfies| B
Loading

File Walkthrough

Relevant files
Bug fix
package.json
Downgrade eslint to resolve peer dependency conflict         

package.json

  • Downgrade eslint from ^10.0.0 to ^9.0.0 in devDependencies
  • Aligns with neostandard@^0.12.1 peer dependency requirement
  • Resolves ERESOLVE conflict that was breaking npm ci
+1/-1     
Dependencies
package-lock.json
Regenerate lock file with resolved dependencies                   

package-lock.json

  • Regenerated to reflect resolved dependency tree
  • Updates eslint and transitive dependencies to compatible versions
  • Ensures npm ci succeeds without ERESOLVE errors

…cy conflict with neostandard

Co-authored-by: lirantal <316371+lirantal@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug CI failure related to dependency installation fix: resolve eslint peer dependency conflict breaking npm ci Feb 21, 2026
Copilot AI requested a review from lirantal February 21, 2026 06:58
@lirantal lirantal marked this pull request as ready for review February 21, 2026 07:26
@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Pin dependency version for build stability

To prevent future build breakages, pin the eslint dependency to the exact
version "9.0.0" instead of using a caret range "^9.0.0".

package.json [87]

-"eslint": "^9.0.0",
+"eslint": "9.0.0",
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly points out that using a caret ^ could re-introduce the dependency conflict in the future, and pinning the version is a valid strategy to improve long-term build stability.

Low
  • More

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 21, 2026

Open in StackBlitz

npm i https://pkg.pr.new/lirantal/ls-mcp@149

commit: 2e44249

@lirantal lirantal merged commit 8f6f767 into main Feb 21, 2026
13 checks passed
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.29%. Comparing base (9e8496a) to head (2e44249).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files          17       17           
  Lines        2138     2138           
  Branches      205      205           
=======================================
  Hits         1567     1567           
  Misses        566      566           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants