feat: add JSON parsing with comment support using jsonc-parser#40
Merged
lirantal merged 1 commit intolirantal:mainfrom Jun 7, 2025
Merged
Conversation
yoavain
force-pushed
the
feat-parse-json-with-comments
branch
from
7c38157 to
729bc9d
Compare
* Handle JSON with comments * Avoid redundant file reads and parsing operations * Added test
yoavain
force-pushed
the
feat-parse-json-with-comments
branch
from
729bc9d to
5a25064
Compare
Collaborator
Author
|
Waiting for |
Owner
|
Looks good to me, let's merge it. Thanks Yoav! p.s. I'm likely going to modularize the MCP server manager code and the files list to sub npm packages so it would be easier to test them separately so don't waste time adding tests to those parts |
Collaborator
Author
|
Sure.. |
Owner
|
I'm afk so can't merge now but I'll add you to the repo when I get back so
you can also merge yourself in the future
…--
Regards,
Liran Tal
On Fri, Jun 6, 2025, 5:19 PM Yoav Vainrich ***@***.***> wrote:
*yoavain* left a comment (lirantal/ls-mcp#40)
<#40 (comment)>
Sure..
app.test.ts fails on main too
—
Reply to this email directly, view it on GitHub
<#40 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACNHU7V4KFHLQTRSID27633CGPNZAVCNFSM6AAAAAB6YAFAG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNBZGQYTCMRVGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
lirantal
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add JSON parsing with comment support using jsonc-parser
Types of changes
Related Issue
#38
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: