Bugfix in bitwise operations, improvements on abstract memory domain #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion and management.
…te for memory representation.
…ng isTop property.
…alyzer/evm-lisa into bug-fix-benchmark-script
… integer offsets are processed.
…o use StackElement for offsets.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and extends various EVM test cases by updating opcode behaviors (especially bitwise operations) and enhancing the abstract memory domain to track unknown values. Key changes include:
- Updated and expanded JSON reports for mstore*, keccak256, if/else, div, and new mstore3 tests
- Added new
.soltest programs for mstore2/3, keccak256, and extendeddiv_eth.solwith signed division tests - Updated
.projectto filter additional Eclipse resources
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| evm-testcases/cfs/mstore2/mstore_eth.sol | New test for 32-byte mstore |
| evm-testcases/cfs/mstore3/mstore_eth.sol | New test for 1-byte mstore |
| evm-testcases/cfs/keccak256/keccak.sol | New Keccak256 test program |
| evm-testcases/cfs/div/div_eth.sol | Extended division tests including signed division |
| .project | Added regex filter for IDE and node_modules folders |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes all the opcodes related to bitwise operations (e.g., SHL, SHR, SAR) and improves the abstract memory domain: now, it is possible to track unknown values in the memory.