Skip to content

fixed some styling bugs - #2

Closed
AadityaJain-Dev wants to merge 1 commit into
lissy93:masterfrom
AadityaJain-Dev:fixing-styling
Closed

fixed some styling bugs#2
AadityaJain-Dev wants to merge 1 commit into
lissy93:masterfrom
AadityaJain-Dev:fixing-styling

Conversation

@AadityaJain-Dev

@AadityaJain-Dev AadityaJain-Dev commented Jul 17, 2023

Copy link
Copy Markdown

While using the website on chrome (Windows OS) I noticed that there is a white space around the <main> tag wrapper.
The changes I made should fix it.

@netlify

netlify Bot commented Jul 17, 2023

Copy link
Copy Markdown

βœ… Deploy Preview for web-check ready!

Name Link
πŸ”¨ Latest commit e7dbca4
πŸ” Latest deploy log https://app.netlify.com/sites/web-check/deploys/64b5099f88ba5a00089880bf
😎 Deploy Preview https://deploy-preview-2--web-check.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lissy93 lissy93 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @AadityaJain-Dev - Thanks for the PR :)
But I think this breaks the alignment of the homepage

Original PR Version
image image

Though I have just realized that I forgot to test on any Chromium-based browsers, and it does look like the positioning is slightly different from Firefox, so I'll look into that. Can you share a screenshot of the broken whitespace, as I don't see that on my end?

@AadityaJain-Dev

Copy link
Copy Markdown
Author

Hey,
sorry for the late reply, I was travelling.
anyway, I am not able to reproduce the issue which I was facing that day, so I guess I will just close the PR.

PS
nice project :)

Thank you

leezhixuan123 pushed a commit to leezhixuan123/web-check that referenced this pull request Oct 9, 2024
@liss-bot

liss-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Hey @AadityaJain-Dev, this has now been implemented by @ojusave in #331, and will be released shortly in 2.2.2 πŸ˜‡

We're sorry this one took so long πŸ˜”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants