Skip to content

fix: correct EIP-55 checksum for LISTA token address on ETH mainnet - #114

Merged
razww merged 1 commit into
masterfrom
hotfix/lista-eth-checksum
Jul 15, 2026
Merged

fix: correct EIP-55 checksum for LISTA token address on ETH mainnet#114
razww merged 1 commit into
masterfrom
hotfix/lista-eth-checksum

Conversation

@LuckyTian1725

@LuckyTian1725 LuckyTian1725 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix an invalid EIP-55 checksum in the Foundry deploy script introduced by PR #113.

PR #113 replaced the placeholder LISTA address with the correct ETH mainnet address but wrote it in all-lowercase form (0x11632069f202b06d5ff56aeb4aabd0662dd1933b). Solidity >=0.8 enforces EIP-55 checksum on address literals at compile time and raises SyntaxError (9429), causing forge script to abort at the compilation stage — deployment cannot proceed.

The Hardhat .ts script is unaffected (ethers.js does not validate checksum).

Change Type

  • Bug fix (compile-time blocker)
  • Configuration change (existing contract)
  • Deploy script (new)
  • New contract
  • Test (new)
  • Upgrade (existing proxy)

Contracts Changed

Contract File Type Description
Deploy script (Foundry) scripts/foundry/eth/deploy_listaRevenueDistributor.sol modified Fix EIP-55 checksum on LISTA token address

Key Changes

File Before After
scripts/foundry/eth/deploy_listaRevenueDistributor.sol 0x11632069f202b06d5ff56aeb4aabd0662dd1933b (invalid checksum) 0x11632069F202B06d5FF56AEB4aAbD0662dd1933b (EIP-55 checksum)

Root Cause

The else branch (ETH mainnet) in deploy_listaRevenueDistributor.sol was never compiled during development — only the Sepolia branch was exercised (its placeholder address happened to be valid checksum). The all-lowercase address slipped through code review because ethers.js accepts it silently.

Verification

forge build scripts/foundry/eth/deploy_listaRevenueDistributor.sol
# Compiler run successful!

Risk Assessment

Area Risk Note
Deploy correctness None Address value unchanged; only letter casing corrected
Runtime impact None One-character-class fix, no logic change
BSC impact None BSC deploy scripts are unchanged

@hashdit-bot

hashdit-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Pull Request Review

This PR makes a single-line fix in the Foundry deployment script for ETH mainnet by changing the LISTA token address literal from all-lowercase to a properly checksummed EIP-55 format. The change resolves Solidity compiler checksum validation errors (SyntaxError 9429) in forge script/forge build flows. No functional logic or access-control behavior was modified beyond address literal formatting correctness.

Sensitive Content

Blockchain Address:

  • 0x11632069F202B06d5FF56AEB4aAbD0662dd1933b (Ethereum address) in scripts/foundry/eth/deploy_listaRevenueDistributor.sol — LISTA token address on ETH mainnet

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@razww razww left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razww
razww merged commit 82436ae into master Jul 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants