fix: correct EIP-55 checksum for LISTA token address on ETH mainnet - #114
Merged
Conversation
Pull Request ReviewThis PR makes a single-line fix in the Foundry deployment script for ETH mainnet by changing the LISTA token address literal from all-lowercase to a properly checksummed EIP-55 format. The change resolves Solidity compiler checksum validation errors ( Sensitive ContentBlockchain Address:
Security IssuesNo serious security issues detected. Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an invalid EIP-55 checksum in the Foundry deploy script introduced by PR #113.
PR #113 replaced the placeholder LISTA address with the correct ETH mainnet address but wrote it in all-lowercase form (
0x11632069f202b06d5ff56aeb4aabd0662dd1933b). Solidity>=0.8enforces EIP-55 checksum on address literals at compile time and raisesSyntaxError (9429), causingforge scriptto abort at the compilation stage — deployment cannot proceed.The Hardhat
.tsscript is unaffected (ethers.jsdoes not validate checksum).Change Type
Contracts Changed
scripts/foundry/eth/deploy_listaRevenueDistributor.solKey Changes
scripts/foundry/eth/deploy_listaRevenueDistributor.sol0x11632069f202b06d5ff56aeb4aabd0662dd1933b(invalid checksum)0x11632069F202B06d5FF56AEB4aAbD0662dd1933b(EIP-55 checksum)Root Cause
The
elsebranch (ETH mainnet) indeploy_listaRevenueDistributor.solwas never compiled during development — only the Sepolia branch was exercised (its placeholder address happened to be valid checksum). The all-lowercase address slipped through code review becauseethers.jsaccepts it silently.Verification
forge build scripts/foundry/eth/deploy_listaRevenueDistributor.sol # Compiler run successful!Risk Assessment